[PATCH 1/1 v2] arm: add generic smp twd timer

[Sascha Hauer]

On Thu, Oct 04, 2012 at 12:55:35PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> on Cortex A9 and Cortex A5 we have a generic timer which we can use as
> clocksource
> 
> Limit the timer frequency to < 25Mhz
> 
> +	return ~readl(twd_base + TWD_TIMER_COUNTER);
> +}
> +
> +static struct clocksource smp_twd_clksrc = {
> +	.read	= smp_twd_read,
> +	.shift	= 20,
> +	.mask	= CLOCKSOURCE_MASK(32),
> +};
> +
> +#define SMP_TWD_MAX_FREQ (25 *1000 * 1000)
> +
> +static int smp_twd_probe(struct device_d *dev)
> +{
> +	u32 tick_rate;
> +	u32 val;
> +	int ret;
> +	u32 presc = 0;
> +
> +	twd_clk = clk_get(dev, NULL);
> +	if (IS_ERR(twd_clk)) {
> +		ret = PTR_ERR(twd_clk);
> +		dev_err(dev, "clock not found: %d\n", ret);

Still do you really really want to bloat the binary with such strings?
This message will only ever be seen by developers. I would find it much
more useful to turn this into dev_dbg and instead add a dev_err in the
driver code when a device fails to probe. That would give a developer
enough hints to know where to increase the debug level.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |