[PATCH] usb.c: warning on USB_MAXINTERFACES overflow
Antony Pavlov
antonynpavlov at gmail.com
Mon Sep 12 06:25:46 EDT 2011
Signed-off-by: Antony Pavlov <antonynpavlov at gmail.com>
---
drivers/usb/core/usb.c | 10 ++++++++++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/core/usb.c b/drivers/usb/core/usb.c
index b01a797..5dc8afe 100644
--- a/drivers/usb/core/usb.c
+++ b/drivers/usb/core/usb.c
@@ -207,6 +207,16 @@ static int usb_parse_config(struct usb_device *dev, unsigned char *buffer, int c
&buffer[index])->bInterfaceNumber != curr_if_num) {
/* this is a new interface, copy new desc */
ifno = dev->config.no_of_if;
+ /* if ifno > USB_MAXINTERFACES, then
+ * next memcpy() will corrupt dev->config
+ */
+ if (ifno > USB_MAXINTERFACES) {
+ printf("ifno = %d > "
+ "USB_MAXINTERFACES = %d !\n",
+ ifno,
+ USB_MAXINTERFACES);
+ break;
+ }
dev->config.no_of_if++;
memcpy(&dev->config.if_desc[ifno],
&buffer[index], buffer[index]);
--
1.7.5.4
More information about the barebox
mailing list