[PATCH 2/2] Add MIPS arch support to barebox

[Sascha Hauer]

On Tue, Jun 28, 2011 at 01:37:46PM +0400, Antony Pavlov wrote:
> On 28/06/2011, Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com> wrote:
> > On 21:13 Mon 27 Jun     , Antony Pavlov wrote:
> >> Only supported board is qemu malta:
> >>   * barebox works in uncached memory;
> >>   * no peripherals support, but serial port.
> >
> > please take a look on here
> > http://git.jcrosoft.org/git?p=barebox.git;a=shortlog;h=refs/heads/mips
> >
> > the work start by Shinya Kuribayashi to support mips and barebox
> >
> > maybe you can merge both
> >
> 
> I took a look on it.
> 
> I can build 'qemu' target with default config, but I can't see
> any output in emulator.
> 
> I can't even build 'malta' target with default config.
> 
> Is it runnable at all?
> 
> I think, that Shinya's concepts can be used in the future, but they
> are very complex for initial mips support.
> 
> IMHO, the Shinya's code is redundant (> 200K ) --- initial support
> must be as small as possible.

+1 for starting small.

> 
> The file Kconfig is overcomplicated. Many variables are really unused:
>  DMA_NONCOHERENT,
>  SWAP_IO_SPACE
>  HW_HAS_PCI
>  SYS_SUPPORTS_{32,64}BIT_KERNEL
>  SYS_SUPPORTS_ARBIT_HZ
>   and others
> 
> In other hand the options ARCH_TEXT_BASE and CPU_BIG_ENDIAN are useful
> just now, but I have missed them.
> 
> But now I see, that I can make my mips support better --- split big
> patch and make some parts of code configurable.

I forgot to say, it's good to split the board support and the
architecture support.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |