[PATCH 1/2 v2] complete: add device name complete support

Jean-Christophe PLAGNIOL-VILLARD plagnioj at jcrosoft.com
Mon Jun 6 06:33:55 EDT 2011


On 11:58 Mon 06 Jun     , Sascha Hauer wrote:
> On Mon, Jun 06, 2011 at 11:11:23AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
> > ---
> >  common/complete.c |   24 ++++++++++++++++++++++++
> >  1 files changed, 24 insertions(+), 0 deletions(-)
> 
> Sorry, this does not work. Pressing eth<TAB> on an empty command
> line expands to
> 
> ethact (correct, this is a command)
> eth0   (almost correct, it misses the '=')
> 
> 'ls <TAB>' expands to
> 
> ls env/ (correct, this is a directory)
> ls eth0 (incorrect, no valid expansion)
> 
> 'ls n<TAB> expands to
> 
> ls nand0     (incorrect, this is a device name and can't be used here=
> ls nfsroot=  (incorrect, no valid expansion)
> 
> Please check the context in which you are calling the different complete
> functions like I suggested in my comment to the last patch.
if devinfo it's valid

for the var evaluation we can use them when we want

ok I check

Best Regards,
J.



More information about the barebox mailing list