serial_ns16550 driver question

Antony Pavlov antonynpavlov at gmail.com
Wed Jul 20 15:51:04 EDT 2011


Hi!

In include/ns16550.h we have:

struct NS16550_plat {
        unsigned int clock;
        unsigned char f_caps;
        /**
         * register read access capability
         */
        unsigned int (*reg_read) (unsigned long base, unsigned char reg_offset);
        /**
         * register write access capability
         */
        void (*reg_write) (unsigned int val, unsigned long base,
                                    unsigned char reg_offset);
};

Why reg_read and reg_write's argument base has type unsigned long?
IMHO pointer type (void * or char *)  is more natural.

-- 
Best regards,
  Antony Pavlov



More information about the barebox mailing list