[PATCH] Add an option to set a board specific banner
Franck JULLIEN
franck.jullien at gmail.com
Mon Jan 3 07:45:18 EST 2011
2011/1/3 Sascha Hauer <s.hauer at pengutronix.de>
> Hi Franck,
>
> On Thu, Dec 30, 2010 at 01:49:34PM +0100, Franck JULLIEN wrote:
> > Allow a board specific fancy banner
> >
> > ---
> >
> > I removed the default fancy banner and do it like Jean-Christophe
> suggested it.
> >
> > common/Kconfig | 6 ++++++
> > common/console.c | 7 ++++++-
> > 2 files changed, 12 insertions(+), 1 deletions(-)
> >
> > diff --git a/common/Kconfig b/common/Kconfig
> > index 617f640..d32c1ce 100644
> > --- a/common/Kconfig
> > +++ b/common/Kconfig
> > @@ -248,6 +248,12 @@ config HUSH_FANCY_PROMPT
> > Allow to set PS1 from the command line. PS1 can have several
> escaped commands
> > like \h for CONFIG_BOARDINFO or \w for the current working
> directory.
> >
> > +config BOARD_BANNER
> > + bool
> > + prompt "allow a board specific fancy banner"
> > + help
> > + Allow to define a custom board banner (you can define
> CONFIG_BOARD_BANNER_TEXT in your config.h)
> > +
> > config HUSH_GETOPT
> > bool
> > depends on SHELL_HUSH
> > diff --git a/common/console.c b/common/console.c
> > index 82786f2..7caef11 100644
> > --- a/common/console.c
> > +++ b/common/console.c
> > @@ -46,7 +46,12 @@ EXPORT_SYMBOL(console_list);
> > static void display_banner (void)
> > {
> > printf (RELOC("\n\n%s\n\n"), RELOC_VAR(version_string));
> > - printf(RELOC("Board: " CONFIG_BOARDINFO "\n"));
> > +
> > +#ifndef CONFIG_BOARD_BANNER
> > +#undef CONFIG_BOARD_BANNER_TEXT
> > +#define CONFIG_BOARD_BANNER_TEXT "Board: " CONFIG_BOARDINFO "\n"
> > +#endif
> > + printf(RELOC(CONFIG_BOARD_BANNER_TEXT));
> > }
>
> I do not really understand this patch. CONFIG_BOARDINFO is board
> specific already, why would we want to add another option?
>
> Sascha
>
> --
> Pengutronix e.K. | |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
>
Hello,
I know CONFIG_BOARDINFO is board specific. However, I think it is more
conveniant
to have the possibility to define a banner text outside the Kconfig. For
example, I use
this in my config.h:
#define CONFIG_BOARD_BANNER_TEXT "\e[1;32m\
***********************************************************************\n\
* Communication board bootloader (ODSFT0152) *\n\
************************************************************************\
\e[0m\n\n"
So may be we could define this kind of banner in the Kconfig.....
Let me know if you don't like this. This patch was kind of a test for me and
we could
forget about it.
Although this patch was very small, we had a lot of discussion around it and
I don't
want to imagine what it is going to be when I submit the nios2 port :)
Best regards,
Franck.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.infradead.org/pipermail/barebox/attachments/20110103/7384ef1e/attachment.html>
More information about the barebox
mailing list