[RFC-PATCH] Fix loads command
Antony Pavlov
antonynpavlov at gmail.com
Mon Aug 22 14:36:24 EDT 2011
On 22 August 2011 10:58, Sascha Hauer <s.hauer at pengutronix.de> wrote:
> Hi Antony,
>
> On Sun, Aug 21, 2011 at 11:08:40PM +0400, Antony Pavlov wrote:
>> Signed-off-by: Antony Pavlov <antonynpavlov at gmail.com>
>> ---
>> commands/Kconfig | 7 +-
>> commands/Makefile | 1 -
>> commands/loads.c | 295 ++++++++++++++++++++++++++++++-----------------------
>> common/Makefile | 1 +
>> 4 files changed, 171 insertions(+), 133 deletions(-)
>
> There seem to be many whitespace cleanups in this patch. Can you please
> post a seperate patch for these for easier review?
...
> A good start would be to cleanup the coding style and to make it compile
> again.
I shall send the new patch series in a few minutes.
This patch series will make loads compile again and fix coding style /
compiler's warning.
For simplicity baudrate switching code was removed.
We can add it in the future. Also it isn't very difficult to switch
from direct memory writing to file descriptor writing.
--
Best regards,
Antony Pavlov
More information about the barebox
mailing list