versatilepb board support is broken

Jean-Christophe PLAGNIOL-VILLARD plagnioj at jcrosoft.com
Wed Aug 10 13:27:06 EDT 2011


On 15:22 Wed 10 Aug     , Antony Pavlov wrote:
> On 9 August 2011 01:05, Jean-Christophe PLAGNIOL-VILLARD
> <plagnioj at jcrosoft.com> wrote:
> > On 23:49 Mon 08 Aug     , Antony Pavlov wrote:
> >> Hi!
> >>
> >> The following patch breaks qemu versatilepb board support:
> >>
> >> c0ff8f7f47fa10b2e683cb0452f659c97aec186f
> >>     versatile: switch to add_generic_device
> >>
> >> The problem is in serial port initialization.
> >>
> >> As versatilepb use only one serial port, this hack make barebox workable
> >> again (of course it is not a good solution).
> >>
> >> --- a/arch/arm/mach-versatile/core.c
> >> +++ b/arch/arm/mach-versatile/core.c
> >> @@ -156,6 +156,7 @@ void versatile_register_uart(unsigned id)
> >>       switch (id) {
> >>       case 0:
> >>               start = VERSATILE_UART0_BASE;
> > I found the issue too
> >
> > but you need to fix all uart
> 
> It was not a fix, it was a DIRTY HACK (but it was very illustrative). :)))
so please put [RFC xxx] or any thing slse in the subject that we see it's not
a patch to apply

Best Regards,
J.



More information about the barebox mailing list