versatilepb board support is broken

Antony Pavlov antonynpavlov at gmail.com
Mon Aug 8 15:49:16 EDT 2011


Hi!

The following patch breaks qemu versatilepb board support:

c0ff8f7f47fa10b2e683cb0452f659c97aec186f
    versatile: switch to add_generic_device

The problem is in serial port initialization.

As versatilepb use only one serial port, this hack make barebox workable
again (of course it is not a good solution).

--- a/arch/arm/mach-versatile/core.c
+++ b/arch/arm/mach-versatile/core.c
@@ -156,6 +156,7 @@ void versatile_register_uart(unsigned id)
 	switch (id) {
 	case 0:
 		start = VERSATILE_UART0_BASE;
+		vpb_clk_create(&ref_clk_24, "uart-pl0110");
 		break;
 	case 1:
 		start = VERSATILE_UART1_BASE;
@@ -171,7 +172,6 @@ void versatile_register_uart(unsigned id)
 	}
 	dev = add_generic_device("uart-pl011", id, NULL, start, 4096,
 			   IORESOURCE_MEM, NULL);
-	vpb_clk_create(&ref_clk_24, dev_name(dev));
 }

 void __noreturn reset_cpu (unsigned long ignored)

-- 
Best regards,
  Antony Pavlov



More information about the barebox mailing list