[PATCH v9 04/12] MIPS: add common MIPS stuff

[Antony Pavlov]

On 3 August 2011 16:54, Jean-Christophe PLAGNIOL-VILLARD
<plagnioj at jcrosoft.com> wrote:
>> index e37b6c5..2b3227a 100644
>> --- a/arch/mips/include/asm/common.h
>> +++ b/arch/mips/include/asm/common.h
>> @@ -24,6 +24,17 @@
>>  #ifndef _ASM_MIPS_COMMON_H_
>>  #define _ASM_MIPS_COMMON_H_
>>
>> -/* nothing special yet */
>> +#define NS16550_READ_WRITE_UART_FUNC(pfx, shift, offset) \
>> +static unsigned int pfx ##_uart_read(unsigned long base, \
>> +             unsigned char reg_idx) \
>> +{                                                                    \
>> +     return __raw_readb((char *)base + (reg_idx << shift) + offset); \
>> +}                                                                    \
>> +                                                                     \
>> +static void pfx ##_uart_write(unsigned int val, unsigned long base, \
>> +             unsigned char reg_idx) \
>> +{                                                                    \
>> +     __raw_writeb(val, (char *)base + (reg_idx << shift) + offset);  \
>> +}                                                                    \
> you can drop this
>
> add the following patch instead as will need readb/w/l and writeb/w/l for
> cfi support anyway

Unfortunately, I can't drop it just now. But I will try to drop it in
nearest future. Apropos, cfi does not work for me just now either.

> otherwise lokks very good

Thanks!

-- 
Best regards,
  Antony Pavlov