[PATCH 2/3] cpuimx35: fix warning

[Sascha Hauer]

Hi Eric,

On Wed, Oct 20, 2010 at 03:40:16PM +0200, Eric Bénard wrote:
> this patch fix the following warning :
> arch/arm/boards/eukrea_cpuimx35/flash_header.c:30: warning: "DEST_BASE" redefined
> arch/arm/mach-imx/include/mach/imx-flash-header.h:29: note: this is the location of the previous definition
> 
> Signed-off-by: Eric Bénard <eric at eukrea.com>
> ---
>  arch/arm/boards/eukrea_cpuimx35/flash_header.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/boards/eukrea_cpuimx35/flash_header.c b/arch/arm/boards/eukrea_cpuimx35/flash_header.c
> index 4163caf..3133995 100644
> --- a/arch/arm/boards/eukrea_cpuimx35/flash_header.c
> +++ b/arch/arm/boards/eukrea_cpuimx35/flash_header.c
> @@ -27,6 +27,7 @@ struct imx_dcd_entry __dcd_entry_section dcd_entry[] = {
>  	{ .ptr_type = 4, .addr = 0xb8001010, .val = 0x00000004, },
>  };
>  
> +#undef DEST_BASE
>  #define DEST_BASE 0x80000000
>  struct imx_flash_header __flash_header_section flash_header = {
>  	.app_code_jump_vector	= DEST_BASE + 0x1000,

Why don't you just use another define instead of redefining DEST_BASE?

Grepping through the other boards there seems to be something wrong
here. The original idea was to let the rom code copy the image to the
address it is linked at to not have to relocate it later. This seems to
be not the case for most boards

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |