Code "borrowed" without attribution to original authors
Wolfgang Denk
wd at denx.de
Tue Oct 5 13:53:54 EDT 2010
Dear Jean-Christophe PLAGNIOL-VILLARD,
In message <20101005162019.GK25320 at game.jcrosoft.org> you wrote:
>
> > > d424ce7 image: factorise image printing contents
> > > 0ceafe1 Replace direct header access with the API routines
>
> > > aba80a2 image: rename IH_CPU to IH_ARCH to be more concistant
> > > 7bd7d59 image: factorise string helper
> for the record the two are not borrowed at all from U-Boot but done based on
> barebox
Oh. Interesting statement. Let me check again.
Your commit:
commit aba80a2d2d0f1b25185246925577ce2108247dde
Author: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
Date: Thu Sep 23 06:48:42 2010 +0200
image: rename IH_CPU to IH_ARCH to be more concistant
So BB used to have IH_CPU and switched to IH_ARCH :
Please compare against this U-Boot commit:
commit b97a2a0a21f279d66de8a9bdbfe21920968bcb1c
Author: Marian Balakowicz <m8 at semihalf.com>
Date: Tue Jan 8 18:14:09 2008 +0100
[new uImage] Define a API for image handling operations
- Add inline helper macros for basic header processing
- Move common non inline code common/image.c
- Replace direct header access with the API routines
- Rename IH_CPU_* to IH_ARCH_*
Signed-off-by: Marian Balakowicz <m8 at semihalf.com>
Pay special attention to the "Rename IH_CPU_* to IH_ARCH_*" part.
Not borrowed? What an extremely unlikely coincidence then! I think
you should try to explain that.
> and as we all known the uImage format come from U-Boot I just sync it
> recently without commit details as we do for Kconfig we do not trac
> modifications details and we respect the copyright. SO I'll repeat myself
> if Marian copyright is missing We will add it with pleasure.
I recommend you to get a clue about what is needed to properly
attribute code to the people who actually wrote it, instead of
submitting it without any due reference and then even claiming you
developed it yourself. I guess you are not interested in having a
reputation as a plagiarist?
Despite your ludicrous statement of "not borrowed at all" I still
assume, for now, this was just an accident, and that bringing it to
your attention is all that is needed to settle the matter. It is
your turn now.
Thanks.
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The following statement is not true. The previous statement is true.
More information about the barebox
mailing list