RFC: change map_base type
s.hauer at pengutronix.de
Thu Nov 25 03:29:39 EST 2010
On Wed, Nov 24, 2010 at 09:09:43PM +0100, Belisko Marek wrote:
> On Wed, Nov 24, 2010 at 3:48 PM, Jean-Christophe PLAGNIOL-VILLARD
> <plagnioj at jcrosoft.com> wrote:
> > On 13:39 Wed 24 Nov , Belisko Marek wrote:
> >> Hi,
> >> fist sparse patches was accepted but doesn't fix all problems.
> >> There is still a lot of sparse problems which complain about incorrect type
> >> in functions read(bwl)/writ(bwl). Over whole codebase to this
> >> functions are passed
> >> u_long or u_int types which is not correct.
> >> e.g. in serial drivers is used for access to registers:
> >> writeb(0x07, dev->map_base + UFCON);
> >> In my opinion it make no sense to use:
> >> writeb(0x07, IOMEM(dev->map_base + UFCON));
> >> Instead change map_base type in include/driver.h to void __iomem *map_base
> >> which should fix a lot sparse problems.
> >> Then only board code when device is initialized use: .map_base =
> >> IOMEM(0x00000...)
> >> Make it sense or there is not necessary to touch it or other way?
> > it's a ressources so it's the right type as in the kernel
> > the driver need to cast based on it's need
> > as done in linux
> You are right. Linus type for map_base is same like in barebox.
> Anyway if you pass some resource to driver it is always re-mapped and
> used remapped value over all code for IO access.
> Maybe best would be cast map_base in probe function of driver with IOMEM() macro
> and this value store in driver structure and use. Good idea?
Yes, I like it.
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
More information about the barebox