[PATCH 2/5] fs: Fix sparse warning.

Sascha Hauer s.hauer at pengutronix.de
Fri Nov 19 03:36:21 EST 2010


On Thu, Nov 18, 2010 at 02:29:28PM +0100, Marek Belisko wrote:
> Patch fix following sparse warning:
> fs/fs.c:757:28: warning: dubious: !x & y

Don't be shy. You actually found a real bug. I changed the commit log a
bit to reflect that. I added this one to master and the others to next.

Sascha

> 
> Signed-off-by: Marek Belisko <marek.belisko at open-nandra.com>
> ---
>  fs/fs.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/fs.c b/fs/fs.c
> index 3b5f284..7d8dea7 100644
> --- a/fs/fs.c
> +++ b/fs/fs.c
> @@ -754,7 +754,7 @@ int mount(const char *device, const char *fsname, const char *_path)
>  	}
>  
>  	fsdev = xzalloc(sizeof(struct fs_device_d));
> -	if (!fs_drv->flags & FS_DRIVER_NO_DEV) {
> +	if (!(fs_drv->flags & FS_DRIVER_NO_DEV)) {
>  		fsdev->backingstore = strdup(device);
>  		if (!device) {
>  			printf("need a device for driver %s\n", fsname);
> -- 
> 1.7.1
> 
> 
> _______________________________________________
> barebox mailing list
> barebox at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list