[PATCH 08/13] mxc_nand: fix correct_data function

[Sascha Hauer]

Hi Baruch,

On Thu, Nov 11, 2010 at 07:25:49AM +0200, Baruch Siach wrote:
> Hi Sascha,
> 
> On Wed, Nov 10, 2010 at 03:53:54PM +0100, Sascha Hauer wrote:
> > The v2 controller has a totally different mechanism to check
> > whether the data we read had ecc errors or not. Implement this.
> > The mechanism in the v2 controller happens to be identical to
> > the v3 controller.
> 
> Does this mean that the current .correct method in not compatible with v2 
> controllers? If so, does this bug makes any read error look like an 
> uncorrectable error? Something else (silent corruption)?

I'm afraid it's silent corruption. As I see it good crc sums can be
detected as bad crc sums and bad crc sums can be detected as good crc
sums if the v1 implementation is used instead of v2.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |