[PATCH 01/12] ARM zImage: do memmap if possible

[Sascha Hauer]

On Tue, Mar 30, 2010 at 12:01:42PM +0200, Peter Korsgaard wrote:
> >>>>> "Sascha" == Sascha Hauer <s.hauer at pengutronix.de> writes:
> 
> Hi,
> 
>  >> Here you're rereading the header as well, instead of everything past
>  >> it like the normal case.
> 
>  Sascha> Yes, mostly because I was too lazy to calculate the offsets.
> 
> You could just have copied it from the line above ;)
> 
>  >> Does this give a significant boost? read() from something memmap'able
>  >> (like NOR) boils down to a memcpy as well, right?
> 
>  Sascha> Hmm, with memmap it's 149ms and with read 156ms in my case. I
>  Sascha> think this is because with memmap it goes down to a single
>  Sascha> memcpy whereas with read we memcpy in chunks of 4k. I
>  Sascha> implemented this out of reflex, but maybe it's really not worth
>  Sascha> the added complexity.
> 
> I imho don't think it's worth it. One of barebox' big advantages is how
> readable and clean the source code is.

Ok, I'll drop this patch.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |