[PATCH net-pu] tftp: fix get

[Sascha Hauer]

Hi Baruch,

On Thu, Jun 24, 2010 at 04:26:16PM +0300, Baruch Siach wrote:
> With this patch tftp start requesting block 0 instead of 1. This fixes
> tftp get on i.MX25 based board with tftpd-hpa server.

This is strange. In case of tftp get this variable is not used for
sending packets. We do not request blocks with a certain number, we only
request a file and ack incoming packets. If you look at 'case TFTP_DATA'
in tftp_handler(), you'll see tftp_block getting overwritten by the
block number of the incoming packet.

The initialization of tftp_block is only used for tftp push. For tftp
push RFC1350 says that the first packet we send has to have block number
one (not zero). 

> 
> tftp push isn't working though. I get:
> 
> error frame: 0x83705178 0x00000882
> 
> from the fec driver. I'll investigate this if I have time.

I also see this message sometimes, but usually this is not a problem.
The transfer continues once the timeout handler triggers and the packet
is resent.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |