[PATCH] init.h: introduce fake define (__init & __initdata) to simplify the linux sync

Baruch Siach baruch at tkos.co.il
Wed Aug 4 02:50:08 EDT 2010


Hi Jean-Christophe,

On Wed, Aug 04, 2010 at 04:20:14AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
> ---
>  include/init.h |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/include/init.h b/include/init.h
> index c5dea07..accc4d0 100644
> --- a/include/init.h
> +++ b/include/init.h
> @@ -1,6 +1,12 @@
>  #ifndef _INIT_H
>  #define _INIT_H
>  
> +/*
> + * fake define to simplify the linux sync
> + */
> +#define __init
> +#define __initdata
> +

IMO, having useless __init/__initdata in the code adds noise, and reduces 
readability.  These can be easily removed as code gets moved from Linux to 
Barebox.

baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -



More information about the barebox mailing list