[PATCH 1/4] i2c: new framework

Juergen Beisert jbe at pengutronix.de
Mon Nov 23 07:54:54 EST 2009


On Montag, 23. November 2009, Marc Kleine-Budde wrote:
> Signed-off-by: Marc Kleine-Budde <mkl at pengutronix.de>
> ---
>  drivers/Kconfig      |    1 +
>  drivers/Makefile     |    1 +
>  drivers/i2c/Kconfig  |    2 +
>  drivers/i2c/Makefile |    1 +
>  drivers/i2c/i2c.c    |  362
> ++++++++++++++++++++++++++++++++++++++++++++++++++
>
> [...]
>
> > +/** 
> + * i2c_transfer - execute a single or combined I2C message
> + * @adap: Handle to I2C bus
> + * @msgs: One or more messages to execute before STOP is issued to
> + *	terminate the operation; each message begins with a START.
> + * @num: Number of messages to be executed.

As we are currently using Doxygen, could you change these comments to its
style? The @<var> is kernel style and will confusing Doxygen.

jbe

-- 
Pengutronix e.K.                              | Juergen Beisert             |
Linux Solutions for Science and Industry      | Phone: +49-8766-939 228     |
Vertretung Sued/Muenchen, Germany             | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686              | http://www.pengutronix.de/  |




More information about the barebox mailing list