[PATCH] commands: Remove reference to non-existent CONFIG_CMD_I2C.

Robert P. J. Day rpjday at crashcourse.ca
Mon Dec 21 06:47:48 EST 2009

On Mon, 21 Dec 2009, Peter Korsgaard wrote:

> >>>>> "Sascha" == Sascha Hauer <s.hauer at pengutronix.de> writes:
>  Sascha> Ok, applied.
>  Sascha> Is a i2c command really useful? For I2C eeproms you would
>  Sascha> create an epprom driver which creates a file under /dev/ which
>  Sascha> you can then access using the usual mm/mw commands.  Maybe an
>  Sascha> i2c command could be useful to register a new device on an I2C
>  Sascha> bus.
> I could see basic I2C access being useful for debugging (of
> non-eeprom devices).

  i was imagining the same thing, but since there's no such support at
the moment, there's little value in leaving that config variable

  just to be clear, i'm a big fan of adding new functionality all at
once, in one logical patch.  when i run my scanning scripts on the
linux kernel, i frequently get *numerous* hits on undefined or
unreferences CONFIG_ variables, which turn out to be because someone
has *partially* added a feature but it's not complete, so you have
mysterious code or variables that no one else seems to reference, with
people saying, "oh, yeah, i'm getting to that, i'll be adding some
code to hook up with that shortly and finish it off."

  personally, i'd rather that didn't happen, just because it's easier
to track paches if they're logically complete and coherent.  in short,
when the time comes to add an "i2c" command, we can put everything
back in in one patch.  sound reasonable?


Robert P. J. Day                               Waterloo, Ontario, CANADA

            Linux Consulting, Training and Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday

More information about the barebox mailing list