can barebox avoid creating typedefs just for struct shortcuts?

Robert P. J. Day rpjday at crashcourse.ca
Mon Dec 21 04:22:43 EST 2009


  i noticed the following:

$ grep -rw gd_t *
arch/arm/include/asm/global_data.h:typedef	struct	global_data gd_t;
arch/ppc/include/asm/global_data.h: * Keep it *SMALL* and remember to set CFG_GBL_DATA_SIZE > sizeof(gd_t)
arch/ppc/include/asm/global_data.h:} gd_t;
arch/sandbox/include/asm/global_data.h:typedef	struct	global_data gd_t;
$

  it's obvious that the typedef "gd_t" is being created as a
time-saving shortcut.  that approach has been actively discouraged in
the main kernel tree for quite some time, as it just obfuscates the
code.  there are, of course, numerous typedefs being used to support
legitimately opaque types, but creating more of them just to save
keystrokes is now frowned upon.

  and since it looks like no one is actually using that one yet, does
anyone mind if i remove it?

rday
--

========================================================================
Robert P. J. Day                               Waterloo, Ontario, CANADA

            Linux Consulting, Training and Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday
========================================================================



More information about the barebox mailing list