[PATCH] wifi: b43: fix incorrect __packed annotation
Simon Horman
simon.horman at corigine.com
Tue May 16 04:00:54 PDT 2023
On Tue, May 16, 2023 at 09:45:42AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd at arndb.de>
>
> clang warns about an unpacked structure inside of a packed one:
>
> drivers/net/wireless/broadcom/b43/b43.h:654:4: error: field data within 'struct b43_iv' is less aligned than 'union (unnamed union at /home/arnd/arm-soc/drivers/net/wireless/broadcom/b43/b43.h:651:2)' and is usually due to 'struct b43_iv' being packed, which can lead to unaligned accesses [-Werror,-Wunaligned-access]
>
> The problem here is that the anonymous union has the default alignment
> from its members, apparently because the original author mixed up the
> placement of the __packed attribute by placing it next to the struct
> member rather than the union definition. As the struct itself is
> also marked as __packed, there is no need to mark its members, so just
> move the annotation to the inner type instead.
>
> Signed-off-by: Arnd Bergmann <arnd at arndb.de>
Reviewed-by: Simon Horman <simon.horman at corigine.com>
More information about the b43-dev
mailing list