From zbynek.spacek at paretdee.com  Fri Feb 10 00:35:54 2023
From: zbynek.spacek at paretdee.com (Zbynek Spacek)
Date: Fri, 10 Feb 2023 08:35:54 GMT
Subject: Silicone rubber - vulcanization
Message-ID: <20230210074500-0.1.4s.a0pr.0.lmijn2kymt@paretdee.com>

Good morning,

a few months ago, we were contacted by a company from your industry, where too high costs were generated by the purchase of silicone rubbers and silicone mixtures with specific properties.

We offered them a wide range of HTV silicone rubbers with technical properties and liquid silicone rubber (LSR), as well as dyes and stabilizers. Competitive conditions made it possible to flexibly adjust to their needs and type of production.

Now the purchase and delivery of rubber runs smoothly, the client has gained a significant increase in savings in relation to the planned budget at the level of several percent per year.

Would you like to check what solutions we can provide you?


Best regards
Zbynek Spacek


From pawel.kamieniecki at culbokie.pl  Fri Feb 10 01:05:35 2023
From: pawel.kamieniecki at culbokie.pl (=?UTF-8?Q? Pawe=C5=82_Kamieniecki ?=)
Date: Fri, 10 Feb 2023 09:05:35 GMT
Subject: Prezentacja
Message-ID: <20230210074501-0.1.1l.37yr.0.7ole9y56d6@culbokie.pl>

Dzie? dobry!

Czy m?g?bym przedstawi? rozwi?zanie, kt?re umo?liwia monitoring ka?dego auta w czasie rzeczywistym w tym jego pozycj?, zu?ycie paliwa i przebieg?

Dodatkowo nasze narz?dzie minimalizuje koszty utrzymania samochod?w, skraca czas przejazd?w, a tak?e tworzenie planu tras czy dostaw.

Z naszej wiedzy i do?wiadczenia korzysta ju? ponad 49 tys. Klient?w. Monitorujemy 809 000 pojazd?w na ca?ym ?wiecie, co jest nasz? najlepsz? wizyt?wk?.

Bardzo prosz? o e-maila zwrotnego, je?li mogliby?my wsp?lnie om?wi? potencja? wykorzystania takiego rozwi?zania w Pa?stwa firmie.


Pozdrawiam,
Pawe? Kamieniecki


From n.petrova at fintech.ru  Fri Feb 10 03:12:28 2023
From: n.petrova at fintech.ru (Natalia Petrova)
Date: Fri, 10 Feb 2023 14:12:28 +0300
Subject: [PATCH] b43legacy: Add checking for null for ssb_get_devtypedata(dev)
Message-ID: <20230210111228.370513-1-n.petrova@fintech.ru>

Function ssb_get_devtypedata(dev) may return null (next call
B43legacy_WARN_ON(!wl) is used for error handling, including null-value).
Therefore, a check is added before calling b43legacy_wireless_exit(),
where the argument containing this value is expected to be dereferenced.

Found by Linux Verification Center (linuxtesting.org) with SVACE

Fixes: 75388acd0cd8 ("[B43LEGACY]: add mac80211-based driver for legacy BCM43xx devices")
Signed-off-by: Natalia Petrova <n.petrova at fintech.ru>
---
 drivers/net/wireless/broadcom/b43legacy/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/broadcom/b43legacy/main.c b/drivers/net/wireless/broadcom/b43legacy/main.c
index 760136638a95..1ae65679d704 100644
--- a/drivers/net/wireless/broadcom/b43legacy/main.c
+++ b/drivers/net/wireless/broadcom/b43legacy/main.c
@@ -3871,7 +3871,7 @@ static int b43legacy_probe(struct ssb_device *dev,
 	return err;
 
 err_wireless_exit:
-	if (first)
+	if (first && wl)
 		b43legacy_wireless_exit(dev, wl);
 	return err;
 }
-- 
2.34.1



From Larry.Finger at lwfinger.net  Fri Feb 10 11:17:12 2023
From: Larry.Finger at lwfinger.net (Larry Finger)
Date: Fri, 10 Feb 2023 13:17:12 -0600
Subject: [PATCH] b43legacy: Add checking for null for
 ssb_get_devtypedata(dev)
In-Reply-To: <20230210111228.370513-1-n.petrova@fintech.ru>
References: <20230210111228.370513-1-n.petrova@fintech.ru>
Message-ID: <ff977e8e-f832-d38d-a6d8-4510d08bf306@lwfinger.net>

On 2/10/23 05:12, Natalia Petrova wrote:
> Function ssb_get_devtypedata(dev) may return null (next call
> B43legacy_WARN_ON(!wl) is used for error handling, including null-value).
> Therefore, a check is added before calling b43legacy_wireless_exit(),
> where the argument containing this value is expected to be dereferenced.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE
> 
> Fixes: 75388acd0cd8 ("[B43LEGACY]: add mac80211-based driver for legacy BCM43xx devices")
> Signed-off-by: Natalia Petrova <n.petrova at fintech.ru>
> ---
>   drivers/net/wireless/broadcom/b43legacy/main.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/broadcom/b43legacy/main.c b/drivers/net/wireless/broadcom/b43legacy/main.c
> index 760136638a95..1ae65679d704 100644
> --- a/drivers/net/wireless/broadcom/b43legacy/main.c
> +++ b/drivers/net/wireless/broadcom/b43legacy/main.c
> @@ -3871,7 +3871,7 @@ static int b43legacy_probe(struct ssb_device *dev,
>   	return err;
>   
>   err_wireless_exit:
> -	if (first)
> +	if (first && wl)
>   		b43legacy_wireless_exit(dev, wl);
>   	return err;
>   }

Looks good to me.

Acked-by: Larry Finger <Larry.Finger at gmail.com>

Thanks,

Larry




From simon.horman at corigine.com  Sat Feb 11 05:45:26 2023
From: simon.horman at corigine.com (Simon Horman)
Date: Sat, 11 Feb 2023 14:45:26 +0100
Subject: [PATCH] b43legacy: Add checking for null for
 ssb_get_devtypedata(dev)
In-Reply-To: <20230210111228.370513-1-n.petrova@fintech.ru>
References: <20230210111228.370513-1-n.petrova@fintech.ru>
Message-ID: <Y+eb9mZntfe6rO3v@corigine.com>

On Fri, Feb 10, 2023 at 02:12:28PM +0300, Natalia Petrova wrote:
> Function ssb_get_devtypedata(dev) may return null (next call
> B43legacy_WARN_ON(!wl) is used for error handling, including null-value).
> Therefore, a check is added before calling b43legacy_wireless_exit(),
> where the argument containing this value is expected to be dereferenced.

I see that is true, however, in that case are resources leaked
due to the ieee80211_free_hw() call in b43legacy_wireless_exit()
not being made?

Moreover, aren't there also unguarded dereferences of wl:

1. In the call to b43legacy_one_core_attach(),
   which would branch to err_wireless_exit on failure.

2. In the call to schedule_work() just about the out: label.

For the record, and because it seems relevant to give contexxt,
b43legacy_probe() looks like this:

static int b43legacy_probe(struct ssb_device *dev,
                         const struct ssb_device_id *id)
{
        struct b43legacy_wl *wl;
        int err;
        int first = 0;

        wl = ssb_get_devtypedata(dev);
        if (!wl) {
                /* Probing the first core - setup common struct b43legacy_wl */
                first = 1;
                err = b43legacy_wireless_init(dev);
                if (err)
                        goto out;
                wl = ssb_get_devtypedata(dev);
                B43legacy_WARN_ON(!wl);
        }
        err = b43legacy_one_core_attach(dev, wl);
        if (err)
                goto err_wireless_exit;

        /* setup and start work to load firmware */
        INIT_WORK(&wl->firmware_load, b43legacy_request_firmware);
        schedule_work(&wl->firmware_load);

out:
        return err;

err_wireless_exit:
        if (first)
                b43legacy_wireless_exit(dev, wl);
        return err;
}


> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE
> 
> Fixes: 75388acd0cd8 ("[B43LEGACY]: add mac80211-based driver for legacy BCM43xx devices")
> Signed-off-by: Natalia Petrova <n.petrova at fintech.ru>
> ---
>  drivers/net/wireless/broadcom/b43legacy/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/broadcom/b43legacy/main.c b/drivers/net/wireless/broadcom/b43legacy/main.c
> index 760136638a95..1ae65679d704 100644
> --- a/drivers/net/wireless/broadcom/b43legacy/main.c
> +++ b/drivers/net/wireless/broadcom/b43legacy/main.c
> @@ -3871,7 +3871,7 @@ static int b43legacy_probe(struct ssb_device *dev,
>  	return err;
>  
>  err_wireless_exit:
> -	if (first)
> +	if (first && wl)
>  		b43legacy_wireless_exit(dev, wl);
>  	return err;
>  }
> -- 
> 2.34.1
> 


From pawel.kamieniecki at cannich.pl  Mon Feb 27 02:23:29 2023
From: pawel.kamieniecki at cannich.pl (=?UTF-8?Q? Pawe=C5=82_Kamieniecki ?=)
Date: Mon, 27 Feb 2023 10:23:29 GMT
Subject: Prezentacja
Message-ID: <20230227095324-0.1.23.1efi.0.y0m484i3r9@cannich.pl>

Dzie? dobry!

Czy m?g?bym przedstawi? rozwi?zanie, kt?re umo?liwia monitoring ka?dego auta w czasie rzeczywistym w tym jego pozycj?, zu?ycie paliwa i przebieg?

Dodatkowo nasze narz?dzie minimalizuje koszty utrzymania samochod?w, skraca czas przejazd?w, a tak?e tworzenie planu tras czy dostaw.

Z naszej wiedzy i do?wiadczenia korzysta ju? ponad 49 tys. Klient?w. Monitorujemy 809 000 pojazd?w na ca?ym ?wiecie, co jest nasz? najlepsz? wizyt?wk?.

Bardzo prosz? o e-maila zwrotnego, je?li mogliby?my wsp?lnie om?wi? potencja? wykorzystania takiego rozwi?zania w Pa?stwa firmie.


Pozdrawiam,
Pawe? Kamieniecki


