[PATCH wireless 1/5] wifi: b43: Correct OpenFW QoS capability warning conditional
Rahul Rameshbabu
sergeantsagara at protonmail.com
Fri Dec 29 20:51:29 PST 2023
Trigger the warning message should be when the OpenFW capability for QoS
does not advertise QoS support. Previously, the warning would be
incorrectly triggered when OpenFW reported QoS capability is present.
Fixes: 097b0e1bf18a ("b43: fix crash with OpenFWWF")
Signed-off-by: Rahul Rameshbabu <sergeantsagara at protonmail.com>
---
drivers/net/wireless/broadcom/b43/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/broadcom/b43/main.c b/drivers/net/wireless/broadcom/b43/main.c
index 92ca0b2ca286..c81117a22ebf 100644
--- a/drivers/net/wireless/broadcom/b43/main.c
+++ b/drivers/net/wireless/broadcom/b43/main.c
@@ -2713,7 +2713,7 @@ static int b43_upload_microcode(struct b43_wldev *dev)
dev->hwcrypto_enabled = false;
}
/* adding QoS support should use an offline discovery mechanism */
- WARN(fwcapa & B43_FWCAPA_QOS, "QoS in OpenFW not supported\n");
+ WARN(!(fwcapa & B43_FWCAPA_QOS), "QoS in OpenFW not supported\n");
} else {
b43info(dev->wl, "Loading firmware version %u.%u "
"(20%.2i-%.2i-%.2i %.2i:%.2i:%.2i)\n",
--
2.42.0
More information about the b43-dev
mailing list