[PATCH 16/31] net: broadcom: changing LED_* from enum led_brightness to actual value
Arend van Spriel
arend.vanspriel at broadcom.com
Sat Jan 22 00:21:58 PST 2022
On 1/21/2022 5:54 PM, Luiz Sampaio wrote:
> The enum led_brightness, which contains the declaration of LED_OFF,
> LED_ON, LED_HALF and LED_FULL is obsolete, as the led class now supports
> max_brightness.
The commit message sounds a bit obscure to me. You say the
led_brightness enumeration is or rather will become obsolete. I don't
understand the reason given "led class now supports max_brightness".
What does that mean?
Also I do not understand the approach here. If the enum is obsolete why
not start with the APIs using it like the led callbacks
brightness_{get,set{,_blocking}}. I suspect that is your next step, but
it seems like unnecessary churn to me.
Anyway, what triggered me to look at this is the fact that we do have a
led.c under drivers/net/wireless/broadcom/brcm80211/brcmsmac
implementing the brightness_set() callback.
Regards,
Arend
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4219 bytes
Desc: S/MIME Cryptographic Signature
URL: <http://lists.infradead.org/pipermail/b43-dev/attachments/20220122/193cc874/attachment.p7s>
More information about the b43-dev
mailing list