[PATCH v2] b43legacy: don't save dentries for debugfs
Kalle Valo
kvalo at codeaurora.org
Tue May 18 18:48:39 BST 2021
Greg Kroah-Hartman <gregkh at linuxfoundation.org> writes:
> There is no need to keep around the dentry pointers for the debugfs
> files as they will all be automatically removed when the subdir is
> removed. So save the space and logic involved in keeping them around by
> just getting rid of them entirely.
>
> By doing this change, we remove one of the last in-kernel user that was
> storing the result of debugfs_create_bool(), so that api can be cleaned
> up.
>
> Cc: Larry Finger <Larry.Finger at lwfinger.net>
> Cc: Kalle Valo <kvalo at codeaurora.org>
> Cc: "David S. Miller" <davem at davemloft.net>
> Cc: Jakub Kicinski <kuba at kernel.org>
> Cc: linux-wireless at vger.kernel.org
> Cc: b43-dev at lists.infradead.org
> Cc: netdev at vger.kernel.org
> Cc: linux-kernel at vger.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
> ---
> .../net/wireless/broadcom/b43legacy/debugfs.c | 29 ++++---------------
> .../net/wireless/broadcom/b43legacy/debugfs.h | 3 --
> 2 files changed, 5 insertions(+), 27 deletions(-)
>
> Note, I can take this through my debugfs tree if wanted, that way I can
> clean up the debugfs_create_bool() api at the same time. Otherwise it's
> fine, I can wait until next -rc1 for that to happen.
Acked-by: Kalle Valo <kvalo at codeaurora.org>
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
More information about the b43-dev
mailing list