[PATCH 07/30] net: wireless: broadcom: b43: main: Add braces around empty statements

Kalle Valo kvalo at codeaurora.org
Fri Aug 14 13:25:31 EDT 2020


Lee Jones <lee.jones at linaro.org> writes:

> On Fri, 14 Aug 2020, Kalle Valo wrote:
>
>> Lee Jones <lee.jones at linaro.org> writes:
>> 
>> > Fixes the following W=1 kernel build warning(s):
>> >
>> >  drivers/net/wireless/broadcom/b43/main.c: In function ‘b43_dummy_transmission’:
>> >  drivers/net/wireless/broadcom/b43/main.c:785:3: warning: suggest
>> > braces around empty body in an ‘if’ statement [-Wempty-body]
>> >  drivers/net/wireless/broadcom/b43/main.c: In function ‘b43_do_interrupt_thread’:
>> >  drivers/net/wireless/broadcom/b43/main.c:2017:3: warning: suggest
>> > braces around empty body in an ‘if’ statement [-Wempty-body]
>> >
>> > Cc: Kalle Valo <kvalo at codeaurora.org>
>> > Cc: "David S. Miller" <davem at davemloft.net>
>> > Cc: Jakub Kicinski <kuba at kernel.org>
>> > Cc: Martin Langer <martin-langer at gmx.de>
>> > Cc: Stefano Brivio <stefano.brivio at polimi.it>
>> > Cc: Michael Buesch <m at bues.ch>
>> > Cc: van Dyk <kugelfang at gentoo.org>
>> > Cc: Andreas Jaggi <andreas.jaggi at waterwave.ch>
>> > Cc: Albert Herranz <albert_herranz at yahoo.es>
>> > Cc: linux-wireless at vger.kernel.org
>> > Cc: b43-dev at lists.infradead.org
>> > Cc: netdev at vger.kernel.org
>> > Signed-off-by: Lee Jones <lee.jones at linaro.org>
>> > ---
>> >  drivers/net/wireless/broadcom/b43/main.c | 6 ++++--
>> >  1 file changed, 4 insertions(+), 2 deletions(-)
>> 
>> Please don't copy the full directory structure to the title. I'll change
>> the title to more simple version:
>> 
>> b43: add braces around empty statements
>
> This seems to go the other way.
>
> "net: wireless: b43" seems sensible.

Sorry, not understanding what you mean here.

>> I'll do similar changes to other wireless-drivers patches.
>
> Thanks.
>
> Does that mean it's been applied, or is this future tense?

It's not applied yet, there will be an automatic "applied" email once I
have done that.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches



More information about the b43-dev mailing list