[PATCH] b43: Replace mdelay with msleep in b43_radio_2057_init_post

Larry Finger Larry.Finger at lwfinger.net
Sat Dec 30 10:49:50 PST 2017

On 12/30/2017 05:08 AM, Jia-Ju Bai wrote:
> b43_radio_2057_init_post is not called in an interrupt handler
> nor holding a spinlock.
> The function mdelay in it can be replaced with msleep, to reduce busy wait.
> Signed-off-by: Jia-Ju Bai <baijiaju1990 at gmail.com>

checkpatch.pl reports the following warning for this patch:

WARNING: msleep < 20ms can sleep for up to 20ms; see 
#26: FILE: drivers/net/wireless/broadcom/b43/phy_n.c:1034:
+       msleep(2);

total: 0 errors, 1 warnings, 0 checks, 8 lines checked

Have you tested to verify that a sleep as long as 20 ms will not cause problems? 
The referenced document suggests a usleep_range() call.

In general, delay changes should never be proposed without testing.


More information about the b43-dev mailing list