[b43] don't unconditionally fall back to CCK if the rate is 6MB OFDM.

Adrian Chadd adrian at freebsd.org
Sun May 15 07:44:51 PDT 2016


On 15 May 2016 at 07:39, Michael Büsch <m at bues.ch> wrote:
> On Sun, 15 May 2016 07:23:25 -0700
> Adrian Chadd <adrian at freebsd.org> wrote:
>
>> @@ -438,7 +446,7 @@ int b43_generate_txhdr(struct b43_wldev *dev,
>>
>>                 rts_rate = rts_cts_rate ? rts_cts_rate->hw_value :
>> B43_CCK_RATE_1MB;
>
> I just noticed that this is incorrect for 5GHz, too.
> Maybe there are more such bugs.

There are other bugs, yes. I'll do some more digging and submit
follow-up patches, including for the rts_rate selection.

I've tested this on BCM4321 on FreeBSD; it came up in a code review of
b43 whilst I was learning about the driver/hardware. I've tested the
change on FreeBSD and it works correctly. I'll setup a separate PC
linux environment next week to test things on.


-adrian



More information about the b43-dev mailing list