[PATCH 1/2] b43: Remove unnecessary synchronize_irq() before free_irq()

Michael Büsch m at bues.ch
Mon Feb 8 14:22:02 PST 2016


On Mon,  8 Feb 2016 21:41:12 +0100
Lars-Peter Clausen <lars at metafoo.de> wrote:

> Calling synchronize_irq() right before free_irq() is quite useless. On one
> hand the IRQ can easily fire again before free_irq() is entered,

Well, that depends on whether the interrupt is shared and whether we
disabled the interrupt mask inside of the device (which we did).

> on the
> other hand free_irq() itself calls synchronize_irq() internally (in a race
> condition free way), before any state associated with the IRQ is freed.

Ok, fair enough.

-- 
Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/b43-dev/attachments/20160208/9a3d5f46/attachment.sig>


More information about the b43-dev mailing list