[PATCH][RFC][RFT] ssb: pick PCMCIA host code support from b43 driver
Larry Finger
Larry.Finger at lwfinger.net
Mon Sep 21 09:38:30 PDT 2015
On 09/21/2015 11:26 AM, Michael Büsch wrote:
> On Mon, 21 Sep 2015 11:14:32 -0500
> Larry Finger <Larry.Finger at lwfinger.net> wrote:
>
>> This patch has been tested on PPC architecture with Linksys WPC54G PCMCIA cards.
>
> Are you sure that this really is a 16 bit PCMCIA card and not a PC-Card?
> If it shows up in lspci, it's not a PCMCIA card.
Point taken. These are indeed PC-Cards in a PCMCIA format.
>> It probably does not matter here, but I prefer that hexadecimal constants in
>> device tables contain only the lower-case versions of a-f. That makes searching
>> for such constants with grep a lot easier.
>
> I prefer coffee over tea. That doesn't make coffee any better, though.
>
> Is it really so that the rest of the kernel only uses lower case here?
> Grep also supports case insensitive regexes, if done correctly. And if
> not everybody uses lower case here, you'll have to do that anyway.
Yes, I know how to use grep to ignore case.
Larry
>
More information about the b43-dev
mailing list