[PATCH] b43: Fix typo in function name

Larry Finger Larry.Finger at lwfinger.net
Mon Jun 29 18:29:24 PDT 2015


On 06/29/2015 07:45 PM, Nik Nyby wrote:
> This fixes a typo in the "b43_lo_g_maintenance_work" function
> name.
>
> Signed-off-by: Nik Nyby <nikolas at gnu.org>
> ---
>   drivers/net/wireless/b43/lo.c    | 4 ++--
>   drivers/net/wireless/b43/lo.h    | 2 +-
>   drivers/net/wireless/b43/phy_g.c | 2 +-
>   3 files changed, 4 insertions(+), 4 deletions(-)

This patch is OK; however, can there really be a typo in a function name? How do 
you ever know that the author did not mean to use a name that looks like a typo?

Please be careful with these.

Acked-by: Larry Finger <Larry.Finger at lwfinger.net>

Larry

>
> diff --git a/drivers/net/wireless/b43/lo.c b/drivers/net/wireless/b43/lo.c
> index 916123a..a335f94 100644
> --- a/drivers/net/wireless/b43/lo.c
> +++ b/drivers/net/wireless/b43/lo.c
> @@ -929,8 +929,8 @@ void b43_lo_g_adjust_to(struct b43_wldev *dev,
>   	b43_lo_write(dev, &cal->ctl);
>   }
>
> -/* Periodic LO maintanance work */
> -void b43_lo_g_maintanance_work(struct b43_wldev *dev)
> +/* Periodic LO maintenance work */
> +void b43_lo_g_maintenance_work(struct b43_wldev *dev)
>   {
>   	struct b43_phy *phy = &dev->phy;
>   	struct b43_phy_g *gphy = phy->g;
> diff --git a/drivers/net/wireless/b43/lo.h b/drivers/net/wireless/b43/lo.h
> index 3b27e20..7b4df38 100644
> --- a/drivers/net/wireless/b43/lo.h
> +++ b/drivers/net/wireless/b43/lo.h
> @@ -80,7 +80,7 @@ void b43_lo_g_adjust_to(struct b43_wldev *dev,
>
>   void b43_gphy_dc_lt_init(struct b43_wldev *dev, bool update_all);
>
> -void b43_lo_g_maintanance_work(struct b43_wldev *dev);
> +void b43_lo_g_maintenance_work(struct b43_wldev *dev);
>   void b43_lo_g_cleanup(struct b43_wldev *dev);
>   void b43_lo_g_init(struct b43_wldev *dev);
>
> diff --git a/drivers/net/wireless/b43/phy_g.c b/drivers/net/wireless/b43/phy_g.c
> index 727ce6e..462310e 100644
> --- a/drivers/net/wireless/b43/phy_g.c
> +++ b/drivers/net/wireless/b43/phy_g.c
> @@ -3004,7 +3004,7 @@ static void b43_gphy_op_pwork_15sec(struct b43_wldev *dev)
>   		   phy->rev == 1) {
>   		//TODO: implement rev1 workaround
>   	}
> -	b43_lo_g_maintanance_work(dev);
> +	b43_lo_g_maintenance_work(dev);
>   	b43_mac_enable(dev);
>   }
>
>




More information about the b43-dev mailing list