[PATCH] b43: fix extpa_gain check for 2GHz

Rafał Miłecki zajec5 at gmail.com
Wed Jul 29 23:54:10 PDT 2015


On 30 July 2015 at 07:40, Kalle Valo <kvalo at codeaurora.org> wrote:
> Hauke Mehrtens <hauke at hauke-m.de> writes:
>
>> On the 2GHz and and on the 5GHZ band only the extpa_gain setting from
>> the 5GHz band was checked. this patch makes it check the property from
>> the correct band.
>>
>> Signed-off-by: Hauke Mehrtens <hauke at hauke-m.de>
>
> Is this a regression? If yes, please add a Fixes line.
>
> Should this go to 4.2?

Not a regression. It's like this for a loooong time.

AFAIK PCI(e) cards don't have external power amplifier, so this code
is most likely used for some fancy SoCs only. There are 3 known SoCs
with N-PHY rev 5 or 6: BCM4717A1, BCM4718A1 & BCM4716B0.

So we may consider taking it for 4.2 without any "Fixes: " line but I
wouldn't care too much about Cc-ing stable.

Hauke: do you agree?

-- 
Rafał



More information about the b43-dev mailing list