[PATCH] drivers:net:wireless: Add mutex locking for function, b43_op_beacon_set_time in main.c

Rafał Miłecki zajec5 at gmail.com
Sat Nov 29 01:04:02 PST 2014


On 29 November 2014 at 09:56, Michael Büsch <m at bues.ch> wrote:
> On Fri, 28 Nov 2014 22:32:30 -0500
> nick <xerofoify at gmail.com> wrote:
>
>> I don't have hardware for this driver on me, so I didn't test it. However this seems to
>> be correct from my reading of the code around this function and other locking related
>> to this driver.
>
> From the current docs:
>
>>  * @set_tim: Set TIM bit. mac80211 calls this function when a TIM bit
>>  *      must be set or cleared for a given STA. Must be atomic.
>
> So it is not allowed to lock a mutex here.

Nicholas please be more careful with your patches. It seems your patch
is wrong, you didn't check the docs and you didn't even say in the
first place that it wasn't tested. You could at least submit with with
RFT tag or sth.

-- 
Rafał



More information about the b43-dev mailing list