[PATCH 1/2] b43: remove leftover code from old devices support

Rafał Miłecki zajec5 at gmail.com
Sun Jun 22 07:07:53 PDT 2014

On 22 June 2014 14:14, Felix Fietkau <nbd at openwrt.org> wrote:
> On 2014-06-20 17:22, Rafał Miłecki wrote:
>> Old devices (A-PHY or B-PHY) are supposed to be supported by b43legacy.
>> We keep phy_a.c as it's needed for G-PHY which shares some design.
>> Signed-off-by: Rafał Miłecki <zajec5 at gmail.com>
> Wouldn't it make sense to move the relevant pieces of phy_a.c to phy_g.c
> and then remove phy_a.c entirely?
> There are pieces in phy_a.c which can be removed entirely, e.g.
> b43_phyops_a and things only used by this struct.

Absolutely, however it needs some effort and time. I'm currently quite
busy with other things in b43.

One could remove b43_phyops_a, then remove newly-unused functions.
Then see what code is not used by G-PHY. However you should keep in
mind, that 5 GHz support for G-PHY may need some functions that are
not called at this moment. So I'd suggest looking at 5 GHz support in
G-PHY first to avoid removing sth that may be needed in the future.


More information about the b43-dev mailing list