bcm43xx-fwcutter bug report

[David Binderman]

Hello there,

[fwcutter.c:497]: (error) Dangerous usage of 'shortname' (strncpy doesn't always null-terminate it).

Source code is

    if (strlen(file->name)> 20) {
        strncpy(shortname, file->name, 18);
        snprintf(filename, sizeof(filename), "%s..", shortname);
    } else
        strcpy (filename, file->name);

Maybe better code

    if (strlen(file->name)> 20) {
        strncpy(shortname, file->name, 18);
        shortname[18] = '\0';
        snprintf(filename, sizeof(filename), "%s..", shortname);
    } else
        strcpy (filename, file->name);

Regards

David Binderman