[PATCH 1/2] b43: mark some functions and structs static

[Rafał Miłecki]

2013/3/27 John W. Linville <linville at tuxdriver.com>:
> On Wed, Mar 27, 2013 at 05:15:50PM +0100, Hauke Mehrtens wrote:
>> This fixes some sparse warnings.
>>
>> Signed-off-by: Hauke Mehrtens <hauke at hauke-m.de>
>> ---
>>  drivers/net/wireless/b43/phy_n.c          |    6 ++++--
>>  drivers/net/wireless/b43/radio_2056.c     |    2 +-
>>  drivers/net/wireless/b43/sdio.h           |    4 ++--
>>  drivers/net/wireless/b43/tables_nphy.c    |    4 ++--
>>  drivers/net/wireless/b43/tables_phy_lcn.c |    6 +++---
>>  5 files changed, 12 insertions(+), 10 deletions(-)
>>
>> diff --git a/drivers/net/wireless/b43/phy_n.c b/drivers/net/wireless/b43/phy_n.c
>> index 1ec0d69..8d15878 100644
>> --- a/drivers/net/wireless/b43/phy_n.c
>> +++ b/drivers/net/wireless/b43/phy_n.c
>> @@ -2789,9 +2789,11 @@ static void b43_nphy_iq_cal_gain_params(struct b43_wldev *dev, u16 core,
>>   * Tx and Rx
>>   **************************************************/
>>
>> -void b43_nphy_set_rxantenna(struct b43_wldev *dev, int antenna)
>> +#if 0
>> +static void b43_nphy_set_rxantenna(struct b43_wldev *dev, int antenna)
>>  {//TODO
>>  }
>> +#endif
>>
>>  static void b43_nphy_op_adjust_txpower(struct b43_wldev *dev)
>>  {//TODO
>
> If this isn't necessary, why not just remove it?

They are used for pointers that AFAIR can't be null.

-- 
Rafał