[PATCH 11/13] b43: HT-PHY: implement RSSI polling
Rafał Miłecki
zajec5 at gmail.com
Thu Mar 7 11:41:14 EST 2013
2013/3/7 Michael Büsch <m at bues.ch>:
> On Thu, 7 Mar 2013 16:47:25 +0100
> Rafał Miłecki <zajec5 at gmail.com> wrote:
>
>> + const u16 ctl_regs[3][2] = {
>> + { B43_PHY_HT_AFE_C1, B43_PHY_HT_AFE_C1_OVER, },
>> + { B43_PHY_HT_AFE_C2, B43_PHY_HT_AFE_C2_OVER, },
>> + { B43_PHY_HT_AFE_C3, B43_PHY_HT_AFE_C3_OVER, },
>> + };
>> + const u16 radio_r[] = { R2059_SYN, R2059_TXRX0, R2059_RXRX1, };
>
>> + u16 phy_regs_to_save[] = {
>> + B43_PHY_HT_AFE_C1, B43_PHY_HT_AFE_C1_OVER,
>> + 0x848, 0x841,
>> + B43_PHY_HT_AFE_C2, B43_PHY_HT_AFE_C2_OVER,
>> + 0x868, 0x861,
>> + B43_PHY_HT_AFE_C3, B43_PHY_HT_AFE_C3_OVER,
>> + 0x888, 0x881,
>> + };
>
> It usually is better to define tables that are constant as "static const",
> so that they are not put on the kernel stack.
Thanks, I'll fix that, will just wait a little longer for more
comments (if any appear)
--
Rafał
More information about the b43-dev
mailing list