chip id 4318 regression: WARN_ON_ONCE(sdata->vif.hw_queue[i] >= n_queues))

[Johannes Berg]

On Fri, 2012-06-08 at 17:44 +0200, Johannes Berg wrote:
> On Fri, 2012-06-08 at 17:43 +0200, Johannes Berg wrote:
> > On Fri, 2012-06-08 at 10:38 -0500, Larry Finger wrote:
> > 
> > > I got the same result as Andre when using open-source firmware - endless MAC 
> > > suspend failures. It works OK with the proprietary fw, with or without a "qos=0" 
> > > module parameter.
> > 
> > I just noticed one more bug -- I need to number the ACs the other way
> > around, changing
> > 	vif->hw_queue[i] = i;
> > to
> > 	vif->hw_queue[i] = 3 - i;
> > 
> > in main.c, because 0 is BK and 3 is VO, rather than 0 VO/3 BK like in
> > mac80211.
> > 
> > http://p.sipsolutions.net/449d71a3c76656f1.txt
> 
> Ahrg! I keep numbering them wrong, this should be fixed:
> http://p.sipsolutions.net/3bbdb9c6294dad70.txt

Nope, still wrong, I shouldn't be using skb_get_queue_mapping but rather
info->index since now mac80211 is giving us the right *queue number*
rather than just *AC*

johannes