[PATCH v6] mac80211: Remove control.sta from struct ieee80211_tx_info and restructure tx-path

[Johannes Berg]

On Thu, 2012-07-26 at 18:17 +0200, Johannes Berg wrote:
> On Thu, 2012-07-26 at 18:09 +0200, Thomas Huehn wrote:
> > The pointer control.sta is removed from ieee80211_tx_info to free up
> > sufficient memory in SKB_CB on the tx-path to enable new annotations
> > per data packet e.g.support of upcoming Transmit Power Control (TPC).
> > Now the control.sta pointer is put on the stack where passed as
> > function parameter to the .tx equivalent (ieee80211_ops) of each
> > affected wireless driver.
> > Therefore a new structure ieee80211_tx_control is added to mac80211.h
> > which holds the sta structure instead. The tx-path of all affected
> > drivers is restructured to respect the chaneges.
> 
> *sigh*
> 
> /home/johannes/sys/wireless/drivers/net/wireless/ti/wlcore/tx.c: In
> function ‘wl1271_skb_queue_head’:
> /home/johannes/sys/wireless/drivers/net/wireless/ti/wlcore/tx.c:622:48:
> warning: ‘hlid’ may be used uninitialized in this function
> [-Wuninitialized]

Those changes make no sense anyway -- you should be able to pass the
station pointer through if it previously used info->control.sta, instead
of doing an (expensive) lookup.

johannes