[PATCH 3.2 REQUEST] b43: HT-PHY: report signal to mac80211

Johannes Berg johannes at sipsolutions.net
Mon Oct 17 10:36:59 EDT 2011


On Mon, 2011-10-17 at 16:27 +0200, Michael Büsch wrote:
> On Sun, 16 Oct 2011 23:30:49 +0200
> Rafał Miłecki <zajec5 at gmail.com> wrote:
> > +	case B43_PHYTYPE_HT:
> > +		/* TODO: is max the right choice? */
> > +		status.signal = max(
> > +			(__s8) max(rxhdr->phy_ht_power0, rxhdr->phy_ht_power1),
> 
> Hm, why is this cast needed? Does it throw a warning?

The cast should probably be a max_t() instead.

johannes




More information about the b43-dev mailing list