[PATCH 3.2] b43: fill ctl1 word on all new PHYs, fix PHY errors

Michael Büsch m at bues.ch
Mon Oct 17 10:24:47 EDT 2011


On Sun, 16 Oct 2011 23:23:56 +0200
Rafał Miłecki <zajec5 at gmail.com> wrote:

> +	if (phy->type >= B43_PHYTYPE_N) {

I must say that I really dislike this. It's error prone (previous patch got it wrong)
and it's hard to read. Just spell out all types or use a switch statement, as appropriate.
It also makes grepping the sources a lot harder.
I don't see any real advantage.

-- 
Greetings, Michael.



More information about the b43-dev mailing list