[PATCH] ssb: Ignore dangling ethernet cores on wireless devices

[Gábor Stefanik]

On Wed, Nov 9, 2011 at 12:50 PM, Gábor Stefanik <netrolller.3d at gmail.com> wrote:
> On Wed, Nov 9, 2011 at 12:14 PM, David Woodhouse <dwmw2 at infradead.org> wrote:
>> On Fri, 2011-01-07 at 19:48 +0100, Michael Büsch wrote:
>>>
>>> +               case SSB_DEV_ETHERNET:
>>> +                       if (bus->bustype == SSB_BUSTYPE_PCI) {
>>> +                               if (bus->host_pci->vendor == PCI_VENDOR_ID_BROADCOM &&
>>> +                                   (bus->host_pci->device & 0xFF00) == 0x4300) {
>>> +                                       /* This is a dangling ethernet core on a
>>> +                                        * wireless device. Ignore it. */
>>> +                                       continue;
>>> +                               }
>>> +                       }
>>> +                       break;
>>
>> Do you also need to check for (bus->host_pci->device / 1000) == 43?
>> Or do the chips with 5-digit 'decimal' IDs not have the Ethernet cores?
>>
>> Would it be better to invert the test and check for != 0x4400?
>
> I do not know of any Broadcom wireless device with a decimal PCI ID
> (as opposed to a decimal Chip ID).

Edit: However, 0x4700 should also be checked, as some BCM43xx chips
use 0x47xx PCI IDs.

>
>>
>> --
>> dwmw2
>>
>
>
>
> --
> Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)
>



-- 
Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-)