[PATCH] b43: Fix bogus compilation warning for phy_n

Rafał Miłecki zajec5 at gmail.com
Thu May 19 18:59:09 EDT 2011


W dniu 20 maja 2011 00:48 użytkownik Larry Finger
<Larry.Finger at lwfinger.net> napisał:
> On 05/19/2011 05:40 PM, Rafał Miłecki wrote:
>>
>> I should have describe where I can see the problem.
>>
>> If error is other than 0 (it can be as the result of "error =
>> b43_nphy_tx_tone(dev, freq, 250, true, false);"), then "last" won't be
>> set in 3256. In 3300 we use "last", no matter what "error" is.
>
> You are correct. I missed the level of indent in line 3256. What
> initialization should be used for last?  It clearly needs to be set to
> something.

http://bcm-v4.sipsolutions.net/802.11/PHY/N/CalTxIqlo does not say
anything about initial value. Guess it should be zero.

-- 
Rafał



More information about the b43-dev mailing list