[PATCH 1/3] b43: replace DMA translation workarounds with just a one, commented

Michael Büsch m at bues.ch
Thu Jul 21 15:34:40 EDT 2011


On Thu, 21 Jul 2011 17:33:51 +0200
Rafał Miłecki <zajec5 at gmail.com> wrote:

> 2011/7/21 Pavel Roskin <proski at gnu.org>:
> > On 07/20/2011 11:35 AM, Michael Büsch wrote:
> >>
> >> On Wed, 20 Jul 2011 13:10:55 +0200
> >> Rafał Miłecki<zajec5 at gmail.com>  wrote:
> >>
> >>> Sorry, for not explaining this well eno
> >>> ugh. I'm afraid of situation where b44 driver supports 64-bit DMA
> >>> device *without* handling this as such a device.
> >>
> >> A b44 or b43legacy device with 64bit DMA engine does not exist.
> >
> > There are many references to "B43legacy_DMA_64BIT" and "dma64_ops" in
> > b43legacy.  I guess they all are unneeded, and so is struct
> > b43legacy_dma_ops.
> >
> > b44 doesn't seem to have DMA64 support.  By the way, the result of
> > ssb_dma_translation() is placed into bp->dma_offset.  I think the word
> > "offset" is misleading.
> 
> Thanks for comment. I didn't have any time to review (&clean?)
> b43legacy, not to mention b44. Unfortunately I'm too busy with b43
> stuff for now. If you have some free time, you're input to the drivers
> is welcome :)
> 

For historical reasons there is unused 64bit dma code in b43legacy. I'm not sure whether it would even work. Probably not. Larry's fixes were most likely not ported over.



More information about the b43-dev mailing list