[PATCH 1/2] bcma: inform drivers about translation bits needed for the board

Rafał Miłecki zajec5 at gmail.com
Tue Jul 19 13:14:01 EDT 2011


W dniu 19 lipca 2011 16:38 użytkownik Pavel Roskin <proski at gnu.org> napisał:
> On 07/19/2011 04:05 AM, Rafał Miłecki wrote:
>>
>> When using DMA, drivers need to pass special translation info to the
>> hardware.
>>
>> Signed-off-by: Rafał Miłecki<zajec5 at gmail.com>
>
> I'm not sure why you are copying it to me.

Upd, I've used bash history and the last send-email was with --cc to you.


>> +       switch (bus->hosttype) {
>> +       case BCMA_HOSTTYPE_PCI:
>> +               return 0x40000000;
>
> This is already implemented in ssb_dma_translation(), and the constant is
> called SSB_PCI_DMA.  I think we need a named constant here as well, either
> SSB_PCI_DMA or a new constant BCMA_PCI_DMA.


-- 
Rafał



More information about the b43-dev mailing list