[RFC] How to rename SSB_TMSLOW_*, B43_TMSLOW_*?
Rafał Miłecki
zajec5 at gmail.com
Wed Feb 16 08:13:32 EST 2011
Except for following 3 defines:
#define SSB_TMSLOW_RESET 0x00000001 /* Reset */
#define SSB_TMSLOW_REJECT_22 0x00000002 /* Reject (Backplane rev 2.2) */
#define SSB_TMSLOW_REJECT_23 0x00000004 /* Reject (Backplane rev 2.3) */
All our SSB_TMSLOW_* and B43_TMSLOW_* defines are some core control
bits. As we now know, core control bits are not SSB specific or TMSLOW
specific.
Should we (and how) define that names in this situation?
For b43 I propose (quite obvious?) B43_CORE_CTL_*.
However what about SSB_TMSLOW_*? George proposed SSB_CORECTL_*, but it
contains "SSB", while that bits are not SSB specific. Same bits are
used on AI bus. Should we use some SSBAI_CORE_CTL_* then? Any other
ideas? Some better maybe?
P.S.
Personally I prefer CORE_CTL over CORECTL (George). Which one should we use?
--
Rafał
More information about the b43-dev
mailing list