[PATCH 0/8] b43: reoder functions in phy_n.c

[Rafał Miłecki]

W dniu 17 grudnia 2011 19:11 użytkownik Larry Finger
<Larry.Finger at lwfinger.net> napisał:
> On 12/17/2011 06:57 AM, Rafał Miłecki wrote:
>>
>> [APPLYING] This patchset is based on top of wireless-next with:
>> b43: mark some vars __maybe_unused in b43_nphy_pmu_spur_avoid
>> applied.
>>
>>
>> As noted on b43-dev, we got really messy in phy_n.c. Functions were
>> implemented quite randomly, with specs appering during development,
>> sometimes without knowing real mining of the routies.
>>
>> That resulted in code hard to read and with some not-so-nice early
>> declarations.
>>
>> This patches makes some cleaning with that code. It moves tons of LOCs,
>> but I think we have to do this finally instead of going deeper and
>> deeper into that mess.
>>
>> As Larry suggested, I've made small patches and tried my best to get
>> them formatted nicely, to have diffs really clean. I've been
>> compiling b43 after each patch, so there shouldn't be any build
>> breakage between.
>>
>> Rafał Miłecki (8):
>>   b43: N-PHY: reorder functions: put basic ones at beginning
>>   b43: N-PHY: reorder functions: collect radio ones
>>   b43: N-PHY: reorder functions: collect samples ones
>>   b43: N-PHY: reorder functions: collect RSSI selects
>>   b43: N-PHY: split gain control workarounds
>>   b43: N-PHY: reorder functions: move RSSI calibration
>>   b43: N-PHY: reorder functions: move rest of workarounds
>>   b43: N-PHY: reorder functions: random clenaups
>>
>>  drivers/net/wireless/b43/phy_n.c | 4575
>> +++++++++++++++++++-------------------
>>  1 files changed, 2301 insertions(+), 2274 deletions(-)
>
>
> ACKed-by: Larry Finger <Larry.Finger at lwfinger.net>
>
> I like all these patches, and you don't have to change anything. Note, that
> cleanups is misspelled in the subject line for #8.

Thanks for looking at this :)

John: If you wish, you can fix my typo in subject line of 0008 :)

-- 
Rafał