[PATCH] b43: Mask out unwanted bits of RX slot address

Rafał Miłecki zajec5 at gmail.com
Sun Aug 14 11:02:27 EDT 2011


W dniu 14 sierpnia 2011 13:35 użytkownik David Woodhouse
<dwmw2 at infradead.org> napisał:
> On Sun, 2011-08-14 at 13:17 +0200, Rafał Miłecki wrote:
>> I wanted to check if firmware ever uses 0x1000 for addressing
>> purposes. To test that I've increased RX ring size to 257 and waited
>> for 8 KiB aligned ring address (to avoid copying 0x1000 bit from
>> address).
>
> Erm, if you increase the ring size to 257, don't you have to allocate
> 8KiB for the ring buffer? If you're still allocating only 4KiB you'll be
> scribbling off the end of it. And if you allocate 8KiB there'll be no
> waiting; it'll *always* be aligned to 8KiB.

That's right. I've now modified B43_DMA_RINGMEMSIZE to be 8 KiB and I
don't get DMA errors anymore. Tested with 5 b43 reloads, the last time
I even used 384 slots in RX ring. Seems to work stable.

-- 
Rafał



More information about the b43-dev mailing list