[PATCH] Fix alignment issues with DMA TX on BCM4331

David Woodhouse dwmw2 at infradead.org
Sun Aug 14 04:04:04 EDT 2011


On Sun, 2011-08-14 at 09:35 +0200, Rafał Miłecki wrote:
> 
> > The brcm80211 driver doesn't; it writes TXCTL last, unconditionally.
> 
> Uh, you mead me read that code... OK:
> 
> if (!di->aligndesc_4k)
>         _dma_ddtable_init(di, DMA_TX, di->txdpa);
> 
> if ((di->dma.dmactrlflags & DMA_CTRL_PEN) == 0)
>         control |= D64_XC_PD;
> OR_REG(&di->d64txregs->control, control);
> 
> if (di->aligndesc_4k)
>         _dma_ddtable_init(di, DMA_TX, di->txdpa); 

Hm, so I lied. Sorry about that. Will send a new patch.

I'll also have another look at the RX path. I had tried enabling RX
after setting the addresses, but that had failed.

-- 
dwmw2




More information about the b43-dev mailing list